Skip to content

Conversation

@wouterj
Copy link
Contributor

@wouterj wouterj commented Jan 5, 2014

No description provided.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may actually be better as ~1.0.

Could we also add instructions in the README for using the dev version?

@MarcelloDuarte What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wouterj Can you change this to ~1.0 please? Thanks.

@wouterj
Copy link
Contributor Author

wouterj commented Jan 13, 2014

@mdavis1982 changed it to 1.*, since using ~1.0 does not make sense (it only makes sense to use ~ instead of * if you use a higher minor version than 0, e.g. ~1.2).

@mdavis1982
Copy link
Member

@wouterj True... But minor versions shouldn't cause BC breaks. ~1.0 would let 1.1, 1.2 etc work and wouldn't need to be changed until 2.0 was out.

@ciaranmcnulty Do you have any thoughts?

@ciaranmcnulty
Copy link
Member

Nope :-)

@mdavis1982
Copy link
Member

@wouterj I'm going to merge this in 😄

mdavis1982 added a commit that referenced this pull request Jan 13, 2014
Update README to remove the @dev requirement.
@mdavis1982 mdavis1982 merged commit 663b576 into phpspec:master Jan 13, 2014
@wouterj
Copy link
Contributor Author

wouterj commented Jan 13, 2014

@mdavis1982 1.* means >=1.0, <=2.0 and ~1.0 means >=1.0, <=2.0 they are equal. It's just that the ~ is not created when you want to say "all versions in the 1.x serie", there is a 1.* (or 1.x) version format for that.

Anyway, thanks for merging :)

@wouterj wouterj deleted the patch-1 branch January 13, 2014 21:28
@mdavis1982
Copy link
Member

@wouterj Thanks for the PR! Glad we got there in the end 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants